include option typescript type check doesn't accept strings

What are you doing?

class User extends Model {
}

User.belongsTo(Country)

User.findAll({include: ['Country']}) // => raises error
User.findAll({include: ['Country'] as any}) // =>  works fine

What do you expect to happen?

No error in the first call.

What is actually happening?

lib/models/index.ts:17:19 - error TS2345: Argument of type '{ include: string[]; }' is not assignable to parameter of type 'FindOptions'.
  Types of property 'include' are incompatible.
    Type 'string[]' is not assignable to type 'Includeable[]'.
      Type 'string' is not assignable to type 'Includeable'.

Environment

Sequelize version: 5.9.0 Node Version: 8 OS: Mojave 10.14.5 If TypeScript related: 3.4.4

[bogdan]

I think that it is ambiguous to specify two option instead of one. I feel myself in nineties when I see that: back then people had to understand machines. Right now, if a software knows what I mean it just does that without asking additional questions aka options.

Woundn’t it be so much easier to read:

findAll({include: ['children', 'parent']})
// then
findAll({include: [{model: Comment, as: 'children'}, {model: Comment, as: 'parent'}])

<OFFTOPIC> I don’t even tell you how much easier it would be to have this then its expanded nested hashes equivalent:

findAll({include: {parent: ['parent'], children: ['children']}) 
// suppose to load parent of a parent and children of children

But that is a story for another time.

[ephys]

This has since been resolved, the issue isn’t present in Sequelize 6 anymore

I also agree that specifying the name of the association:

include: ['children']
// or if you need more options
include: [{ association: 'children', ... other options }]

is generally better than specifying a model+as pair:

include: [{ model: User, as: 'children' }]