Include problem for multiple foreign keys of the same model

Hi folks, I just found a problem in the case shown below. I don’t know yet, whether it’s a wrong behavior or whether I did something wrong. It’s basically about the List -> Task table join.

1.) It doesn’t matter what include options I take, there is no chance to join both foreign keys. Even something like “include: { all:true }” doesn’t work.

2.) The current result looks like:

[{
    "createdAt": "...",
    "updatedAt": "...",
    "dailyTask": 1,
    "weeklyTask": 2,
    "Task": {
        "id": 2,
        "description": "clean your room",
        "createdAt": "...",
        "updatedAt": "..."
    }
}]

But is there a chance to get it like, or wouldn’t be it actually better to have it like:

[{
    "createdAt": "...",
    "updatedAt": "...",
    "dailyTask": 1,
    "weeklyTask": {
        "id": 2,
        "description": "clean your room",
        "createdAt": "...",
        "updatedAt": "..."
    }
}]

And what I’m actually trying to have, should look like:

[{
    "createdAt": "...",
    "updatedAt": "...",
    "dailyTask": {
        "id": 1,
        "description": "brush your teeth",
        "createdAt": "...",
        "updatedAt": "..."
    },
    "weeklyTask": {
        "id": 2,
        "description": "clean your room",
        "createdAt": "...",
        "updatedAt": "..."
    }
}]

Any idea, whether it’s a bug, or how I could do it?

var co = require('co');
var Sequelize = require('sequelize');
var sequelize = new Sequelize('postgres://postgres:postgres@localhost:5432/test', {
    logging: false
});

// Models
var Task = sequelize.define('Task', {
    description: Sequelize.STRING
});

var List = sequelize.define('List');

// Assoziations
Task.hasMany(List, {
    foreignKey: 'dailyTask'
});

Task.hasMany(List, {
    foreignKey: 'weeklyTask'
});

List.belongsTo(Task, {
    foreignKey: 'dailyTask'
});

List.belongsTo(Task, {
    foreignKey: 'weeklyTask'
});

co(function*() {

    var connection = yield sequelize.sync({
        force: true
    });

    var dailyTask = yield Task.create({
        description: 'brush your teeth'
    });

    var weeklyTask = yield Task.create({
        description: 'clean your room'
    });

    var list = yield List.create({
        dailyTask: dailyTask.id,
        weeklyTask: weeklyTask.id
    });

    var result = yield List.findAll({
        include: [Task]
    });

}).catch(function(err) {
    console.log(err);
});

[ppetzold]

Hi @pmhpereira, here the solution related to the example above:

List.belongsTo(Task, {
    as: 'weeklyTask',
    foreignKey: 'weeklyTaskFk'
});

When you want to join the Task table, simply do the following on the include object:

{
    include: [{
            model: Task,
            as: 'weeklyTask'
     }]
}

Hope it helps!

[mickhansen]

You’ll need to add an alias to one or both of those associations, currently they are overwriting eachother. Something like:

List.belongsTo(Task, {
    as: 'dailyTask',
    foreignKey: 'dailyTask'
});

List.belongsTo(Task, {
    as: 'weeklyTask',
    foreignKey: 'weeklyTask'
});

However it’s not possible to have an association be named the same as a foreign key, so you need to either rename your foreign keys or set your association aliases to something different.

Closing since a question (although still happy to help)