mariadb: showAllTables lists tables from other databases

What are you doing?

With mariadb, showAllTables lists all tables on the server (except system tables), rather than only those tables in the current database (which seems to be the behavior with other dialects, in particular mysql and postgres).

  const sequelize = new Sequelize(config.dbUrl);
  console.log(await sequelize.getQueryInterface().showAllTables());

What do you expect to happen?

[]

What is actually happening?

Tables from other databases on the server.

Notably, this means that dropAllTables will attempt to clear out other databases, too.

The query seems to be using information_schema.tables, but (unlike Postgres) information_schema is global in MySQL/MariaDB. (Switching dialect to mysql, which uses SHOW TABLES, works.)

Dialect: mariadb Dialect version: mariadb@2.0.3 Database version: 10.3 Sequelize version: master Tested with latest release: Yes

[sushantdhiman]

🎉 This issue has been resolved in version 5.19.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[rusher]

Sequelize documentation about showAllTables indicate

This method returns the name of all existing tables in the database.

So either documentation must be changed to “all existing tables in the schema”. or current implementation is ok.

I think there is some confusion here :

first compare with MySQL sequelize implementation. MySQL implementation in sequelize has no schema handling (a table ‘TABLE’ with schema ‘SCHEMA’ will result creating a table ‘SCHEMA_TABLE’ in current schema). MariaDB sequelize implementation result creating a SCHEMA.TABLE table. So thing are not really comparable.

When comparing with other DB that support schema in sequelize (mssql and postgresql) Other do :

• mssql : “SELECT TABLE_NAME, TABLE_SCHEMA FROM INFORMATION_SCHEMA.TABLES” meaning listing all tables in all schemas of current database.
• postgresql: “SELECT table_name FROM information_schema.tables WHERE table_schema = ‘public’ AND table_type LIKE ‘%TABLE’ AND table_name != ‘spatial_ref_sys’;” listing all tables for ‘public’ schema.

So not sure what to do there.

If to be done, correction would be:

--- lib/dialects/mariadb/query-generator.js	(revision 96f5b0e93fb396ef540afc61c1f626534963695e)
+++ lib/dialects/mariadb/query-generator.js	(date 1553764748334)
@@ -29,7 +29,7 @@
   }
 
   showTablesQuery() {
-    return 'SELECT TABLE_NAME, TABLE_SCHEMA FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA NOT IN (\'MYSQL\', \'INFORMATION_SCHEMA\', \'PERFORMANCE_SCHEMA\') AND TABLE_TYPE = \'BASE TABLE\'';
+    return 'SELECT TABLE_NAME, TABLE_SCHEMA FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = SCHEMA() AND TABLE_TYPE = \'BASE TABLE\'';
   }