Need a VARBINARY data type
See original GitHub issueSequelize currently doesn’t have a native string type that maps to an easily indexable VARBINARY in MySQL.
This is going to be a growing issue due to utf8mb4, under which the practice (that Sequelize also uses) of using VARCHAR(255) and InnoDB leads to indexes that are too large and cause CREATE TABLE to fail. With the new charset limitations, some columns will simply use a smaller index size; while others will be better off using a VARBINARY. For example, a sorted title index would likely be better off with a utf8mb4 index with a smaller size and a column storing the string identifier for a facebook/google/etc… account would be best off switching to a VARBINARY.
Note that STRING.BINARY
will not work because that is for VARCHAR(255) BINARY
which still use utf8mb4 and just use the _bin charset, they still use 4 bytes per character in indexes. Also BLOB
makes for indexing issues, our inherent problem.
Naming ideas: STRING.RAW
, VARBINARY
This should be relatively simple for someone who knows how data-types.js works to do. I can’t submit a patch set since I don’t understand enough about how the oids
in the pg data-types.js file works.
Issue Analytics
- State:
- Created 7 years ago
- Comments:13 (5 by maintainers)
Not only
VARBINARY
is needed, we need support forBINARY
too.Both options are far different from VARCHAR and CHAR, since
BINARY
is treated like an opaque vale, without the risk of encoding-issues.At our company we’re using BINARY to encode our IDs, which are similar to UUIDs… but not the same. And we’re using a BINARY column to decrease memory usage.
+1
I will look into adding it, if I can, but I suspect that it is more complicated than meets the eye… given that no one has taken this on already.
Edit:
After a small amount of investigating, it really doesn’t seem all that important, since Sequelize doesn’t do much with the type, anyway. There might be some advanced reasons to need the data type, but, on the surface, it doesn’t seem like it would give you very much.
I found this…