queryInterface.removeColumn doesn't drop enum type (Postgres)

What are you doing?

I have the a migration that removes a column with an ENUM type. Reverting the migration fails because Sequelize didn’t drop the enum type, and reversion fails when it tries to recreate the already-existing type.

Maybe this is intended behavior, but I would think that removeColumn should always clean up everything that addColumn or sync created.

// @flow

import type SequelizeClass, {QueryInterface} from 'sequelize'

const Channels = 'Channels'

module.exports = {
  async up(queryInterface: QueryInterface, Sequelize: Class<SequelizeClass>): Promise<void> {
    await queryInterface.removeColumn(Channels, 'mode')
  },
  async down(queryInterface: QueryInterface, Sequelize: Class<SequelizeClass>): Promise<void> {
    await queryInterface.addColumn(Channels, 'mode', {
      type: Sequelize.ENUM('ANALOG_INPUT', 'DIGITAL_INPUT', 'DIGITAL_OUTPUT', 'DISABLED'),
      allowNull: false,
      defaultValue: 'DISABLED',
    })
  },
}

What do you expect to happen?

The down method succeeds after up has been performed

What is actually happening?

down results in the following error:

SequelizeDatabaseError: type "enum_Channels_mode" already exists

Dialect: postgres Dialect version: 6.4.2 Database version: 10 Sequelize version: 4.29.2 Tested with latest release: Yes (If yes, specify that version)

Note : Your issue may be ignored OR closed by maintainers if it’s not tested against latest version OR does not follow issue template.

[jedwards1211]

@sushantdhiman did you guys assume that Postgres can’t handle that properly? Looks like it can: https://www.postgresql.org/docs/8.2/static/sql-droptype.html

DROP TYPE [ IF EXISTS ] name [, ...] [ CASCADE | RESTRICT ]

RESTRICT Refuse to drop the type if any objects depend on it. This is the default.

[sushantdhiman]

Actually this is a duplicate of long standing issue https://github.com/sequelize/sequelize/issues/2554