Question on usage of timezone in options

What you are doing?

Let’s say we specify timezone as such:

var sequelize = new Sequelize({
    // ...
    timezone: "+08:00"
});

What do you expect to happen?

Assuming I have a column with Type: Sequelize.DATE

When I insert 2010-01-01 09:00 for that column, Sequelize stores 2010-01-01 09:00 into the database without converting the value to UTC timezone which is correct.

However, when I query for that same column, Sequelize then returns me 2010-01-01T09:00Z, with a Z at the back.

What is actually happening?

Shouldn’t the results be 2010-01-01T09:00+08:00 instead of 2010-01-01T09:00Z since the date is not in UTC timezone?

Dialect: mssql Database version: MSSQL 2014 Sequelize version: 3.0

[harshithkashyap]

Since the datatypes are different, if we change it on v3, sequelize models will use DATETIMEOFFSET but the database has DATETIME2 datatype. You would need to convert the existing datetime2 to datetimeoffset. If you create new tables without datatype​ change, you’ll have some in old datatype and some in new. Hence it’s a BC. You can submit a PR to v3 and add a note in change log under BC section.

[iamjoyce]

@harshithkashyap Do you mind elaborating on why is this a breaking change? I was comparing the files in master and v3 in this case, and I think v3 can be modified the same way.

I can submit a PR to v3, just that I am curious on why is this counted as a breaking change.

Are you referring to this - #7419?

Thanks