[Suggestion] JSON output for .find() with raw & include

What you are doing?

Use .find() with raw & include.

Post.findAll({
  raw: true,
  include: [Tag]
});

What do you expect to happen?

{id: 1, ..., Tag: {id: 1, ...}}

What is actually happening?

{id: 1, ..., 'Tag.id': 1, ...}}

Suggestion

As postgres 9.2 added row_to_json function, raw query can be constructed as:

SELECT "Posts".*, row_to_json("Tags".*) AS "Tag" FROM "Posts" INNER JOIN "Tags" ON ("Posts".tid = "Tags".id);

which give the expected JSON result and should improve .find() performance.

Related issues: #1830 #3682 #3885 #4311 #5685 #5708 #6122

[tomoat]

Post.findAll({
  raw: true,
  nest: true,
  include: [Tag]
});

This problem should be as early does not exist

[dossin]

For me on MySQL, it will be a major performance boost. Hope you will address it.

It seems that all major DB have this feature now. JS is slow compare to native DB function.

A first step could be to just use JSON_OBJECT at first level to give the the same results as now but on the DB side.

Exemple : SELECT JSON_OBJECT( ‘lastName’, lastName, ‘firstName’, firstName ) FROM users;

=>

[{“lastName”: “Cell”, “firstName”: “Ance”} {“lastName”: “Laure”, “firstName”: “Varner”}]