TypeError: Cannot read property 'replace' of undefined (when using limit without order or primary key)

This is not necessarily a bug, just a request for better error messages.

Example: You have a model with no primary key, and you use findAll() with “limit” but no “order”:

sequalize.table.findAll({
    limit: 100
})

You get this error:

TypeError: Cannot read property 'replace' of undefined
    at Object.QueryGenerator.quoteIdentifier (PROJECT_ROOT\node_modules\sequelize\lib\dialects\mssql\query-generator.js:494:30)
    at Object.QueryGenerator.addLimitAndOffset (PROJECT_ROOT\node_modules\sequelize\lib\dialects\mssql\query-generator.js:592:26)
    at Object.QueryGenerator.selectQuery (PROJECT_ROOT\node_modules\sequelize\lib\dialects\abstract\query-generator.js:1473:27)
    at QueryInterface.select (PROJECT_ROOT\node_modules\sequelize\lib\query-interface.js:674:25)
    at null.<anonymous> (PROJECT_ROOT\node_modules\sequelize\lib\model.js:1330:32)
    at tryCatcher (PROJECT_ROOT\node_modules\bluebird\js\main\util.js:26:23)
    at Promise._settlePromiseFromHandler (PROJECT_ROOT\node_modules\bluebird\js\main\promise.js:503:31)
    at Promise._settlePromiseAt (PROJECT_ROOT\node_modules\bluebird\js\main\promise.js:577:18)
    at Async._drainQueue (PROJECT_ROOT\node_modules\bluebird\js\main\async.js:128:12)
    at Async._drainQueues (PROJECT_ROOT\node_modules\bluebird\js\main\async.js:133:10)
    at Immediate.Async.drainQueues [as _onImmediate] (PROJECT_ROOT\node_modules\bluebird\js\main\async.js:15:14)
    at processImmediate [as _immediateCallback] (timers.js:358:17)

The code is here:

if (options.limit || options.offset) {
  if (!options.order || (options.include && !subQueryOrder.length)) {
    fragment += (options.order && !isSubQuery) ? ', ' : ' ORDER BY ';
    fragment += this.quoteIdentifier(model.primaryKeyAttribute);
  }
  ...

It would be nicer to have an error that you need to specify either order or have a primary key. A simple assert or “if () throw new Error()” would be fine.

Again - not necessarily a bug, since you need to have order-by in order to use limit, but a confusing error message.

[sushantdhiman]

Works in 5.0.0-beta.11

const Sequelize = require('./index');
const sequelize = require('./test/support').createSequelizeInstance();

const History = sequelize.define('history', {
  amount: Sequelize.INTEGER
});

History.removeAttribute('id');


(async () => {
  await sequelize.sync({ force: true });

  const r = await History.findAll({
    limit: 100
  });

  console.log(r);
})()

Executing (default): DROP TABLE IF EXISTS `histories`;
Executing (default): DROP TABLE IF EXISTS `histories`;
Executing (default): CREATE TABLE IF NOT EXISTS `histories` (`amount` INTEGER, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `histories`
Executing (default): SELECT `amount`, `createdAt`, `updatedAt` FROM `histories` AS `history` LIMIT 100;
[]

[manast-apsis]

If you get an unhandled exception it is a bug… Seems like in current versions this error is still possible, unfortunately on a big codebase with many models, finding which one causes this exception is like finding a needle in a haystack.