question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move SerilogLoggerFactory to Serilog.Extensions.Logging

See original GitHub issue

From a distance, it seems that while SerilogWebHostBuilderExtensions deals with bona fide ASP.NET concerns (e.g IWebHostBuilder), SerilogLoggerFactory would be better placed in a more generic .NET Core library. Perhaps Serilog.Extensions.Logging.

There’s also the possibility that I’m completely insane. 😃

Of course if not, I realize this would be a breaking change but maybe something to consider in the next major version of this library.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

4reactions
ChrisSimmonscommented, Jul 2, 2018

I’ll happily take this task (unless of course someone else comes along and does the hard work)

2reactions
khellangcommented, Jul 1, 2018

It could be moved and type-forwarded, since this package already depends on Serilog.Extensions.Logging 😊

Read more comments on GitHub >

github_iconTop Results From Across the Web

Can a Serilog.ILogger be converted to a Microsoft. ...
I have code that logs to Microsoft.Extensions.Logging.ILogger (and extension methods, mostly). I have configured Serilog to actually do the ...
Read more >
How To Start Logging With .NET
Logging with built-in tools; Logging with Serilog; Logging with NLog ... we are going to show you is to use the shortcut: Ctrl...
Read more >
Adaptive Library Logging with Microsoft.Extensions.Logging
To demonstrate how we can build these loggers, let's take the example of logging out the Console with Serilog. To do this you...
Read more >
.NET Core Logging With LoggerFactory: Best Practices and ...
How to Use the Logging API from Everywhere; Extend the Microsoft.Extensions.Logging API Functionality by Using NLog or Serilog Providers. Let's get started.
Read more >
Serilog vs. Microsoft Extensions Logging: Which to Use? - Loupe
Serilog can be initiated beforehand and log the whole thing (although, the rest of the application can be written to MEL, and maybe...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found