Request: pass less data into ReadFrom.Configuration

This is the typical setup:

var configuration = getConfiguration();
var logger = new LoggerConfiguration()
  .ReadFrom.Configuration(configuration);
  .CreateLogger();

However that passes the entire appsettings.json into ReadFrom.Configuration(). Which is not a good idea - Serilog should get only that config data it needs, no more.

It would be more robust to OPTIONALLY replace this:

.ReadFrom.Configuration(configuration);

with this:

.ReadFrom.Configuration(configuration.GetSection("Serilog"));

Both forms would be allowed to ensure backwards compatibility. Serilog would then need to decide whether the json tree it gets has “Serilog” as the root node, or not, and proceed accordingly.

[tsimbalar]

Hi and thank you for opening an issue.

I believe both overloads already exist :

public static LoggerConfiguration Configuration(
    this LoggerSettingsConfiguration settingConfiguration,
    IConfiguration configuration,
    DependencyContext dependencyContext = null)
    {}

public static LoggerConfiguration ConfigurationSection(
    this LoggerSettingsConfiguration settingConfiguration,
    IConfigurationSection configSection,
    DependencyContext dependencyContext = null)
    {}

Doesn’t that cover your remarks ?

Thanks

[lonix1]

Also true. And in that case there would be duplication of such connection strings which is a recipe for trouble.

I’m glad the overload exists because it’s good enough for my use case.