No path formats supported

It seems the extension WriteTo.File does not support path formats like the ‘old’ RollingFile does. I see Specifier.cs from serilog-sinks-rollingfile and TemplatedPathRoller which is very similar to the PathRoller found in this project.

It seems easy to support path templating here (since the code is very similar and can be transferred), but maybe I’m missing something here; was not templating in this project intentional? If so, why?

Thanks!

[nblumhardt]

Hi Lars,

It is a shame though that the yyyMMddHHmm format is not editable.

I think a customizable format is a fair feature to add, I definitely wouldn’t rule it out in the future, but doing a good job of it seems like it will be non-trivial. Needs a lot of careful analysis around filename parsing, anyway - having the sink delete files that it didn’t create is something of a doomsday scenario 😃 It would also be necessary to ensure that whatever format is used can be reliably parsed to the right resolution - yyyy is never going to work for a monthly rolling file, for example, and that locale doesn’t cause anything crazy to happen. Need to figure out the constraints and how we might detect problems.

How are these packages going to co-exist in the future?

Serilog.Sinks.RollingFile is so widely-used I don’t think it’ll become “legacy” in the near future - we’ll encourage people to use the File package, but if someone took the lead on RollingFile there’s room for it to continue evolving. (Having the more conservative File implementation actually takes some of the pressure off of RollingFile - perhaps it can even move a bit faster now! 😃)

[LarsWesselius]

Hey,

Thanks for the explanation 😃 I’ll keep a close eye on the projects going forward.