basePath support broken in 1.19.0

Describe the bug

When using the basePath and trailingSlash settings in next.config.js, the lambda creates an incorrect url in serverless-component 1.19.0-alpha.27

Actual behavior

With this config in next.config.js:

module.exports = {
  trailingSlash: true,
  basePath: "/nl"
  ...
}

When I do the following request: curl -v https://xxxxxxx.cloudfront.net/nl/zoek

I get this response:

< HTTP/2 308
< content-length: 0
< server: CloudFront
< date: Mon, 18 Jan 2021 08:41:00 GMT
< location: /nl%2Fzoek/
< refresh: 0;url=/nl%2Fzoek/

Expected behavior

When I do this response curl -v https://xxxxxxx.cloudfront.net/nl/zoek I expect the page zoek.tsx to be rendered.

Steps to reproduce

Configure basePath & trailingSlash & deploy with serverless-component 1.19.0

Versions

• @sls-next/serverless-component version: @sls-next/serverless-component@1.19.0-alpha.27
• Next.js version: 10.0.4

[dphang]

Fixed and published in @sls-next/serverless-component@1.19.0-alpha.28

[dphang]

Ah, thanks, I think it seems to be a similar issue as in: https://github.com/serverless-nextjs/serverless-next.js/pull/868. Because Next.js changed their internal redirect regex for Next 10.0.3 and then again in 10.0.4, we needed to add it to our list to remove since we have our own redirect for trailing slash (the reason is for better performance). We need to remove these from routes-manifest.json as they interfere with our own redirects:

  "redirects": [
    {
      "source": "/:file((?!\\.well-known(?:/.*)?)(?:[^/]+/)*[^/]+\\.\\w+)/",
      "destination": "/:file",
      "internal": true,
      "statusCode": 308,
      "regex": "^(?:/((?!\\.well-known(?:/.*)?)(?:[^/]+/)*[^/]+\\.\\w+))/$"
    },
    {
      "source": "/:notfile((?!\\.well-known(?:/.*)?)(?:[^/]+/)*[^/\\.]+)",
      "destination": "/:notfile/",
      "internal": true,
      "statusCode": 308,
      "regex": "^(?:/((?!\\.well-known(?:/.*)?)(?:[^/]+/)*[^/\\.]+))$"
    }
  ],

It looks like for Next 10.0.4 there is a new internal property added so we can easily identify it.

Edit: as a side note, I also need to figure out why the e2e tests didn’t catch it as it should install the latest Next 10.0.x version each time (no cache or anything)