Removed pages still accessible

Hey, when I un-publish a blog post and build+deploy, the old URLs still are accessible. I assume the files still exist in Cloudfront. @dphang is this something you are aware of / is this supported by this framework?

Describe the bug

• Un-published URLs are still accessible

Actual behavior

• Can visit the page

Expected behavior

• Page gives a 404

Steps to reproduce

• Deploy a page and visit the URL
• Un-publish the page
• Redeploy
• Refresh the URL and it will still be available

Versions

• OS/Environment: Deployed from Alpine linux, dev machine is MacOS Big Sur
• @sls-next/serverless-component version: 1.19.0-alpha.3
• Next.js version: 9.5.5

Additional context

• This is a SSG page (getStaticPaths + getStaticProps)

[dphang]

Yes, I think for Lambda@Edge should do it, even though it takes 1-2 minutes longer to deploy (possibly) it will avoid any issues with old cached pages. I’ll add it to the roadmap. You can just set invalidation paths to empty and invalidate yourself using AWS SDK. Here is example how you can poll for the distribution to be ready:

async function checkCloudFrontDistributionReady(
  distributionId: string,
  waitDuration: number,
  pollInterval: number
): Promise<boolean> {
  const startDate = new Date();
  const startTime = startDate.getTime();
  const waitDurationMillis = waitDuration * 1000;

  const cloudfront = new AWS.CloudFront();

  while (new Date().getTime() - startTime < waitDurationMillis) {
    const result = await cloudfront
      .getDistribution({ Id: distributionId })
      .promise();

    if (result.Distribution?.Status === "Deployed") {
      return true;
    }

    console.info(
      `Distribution ${distributionId} is not yet ready. Retrying in ${pollInterval} seconds.`
    );
    await new Promise((r) => setTimeout(r, pollInterval * 1000));
  }

  return false;
}

[kentobento]

@dphang Great, thanks!