Rewrites to /api paths are resulting in 404

Describe the bug

A configuration of next.config.js as follow:

module.exports = {
  target: 'serverless',
  rewrites: async () => [
    {
      source: '/:path*',
      destination: '/:path*',
    },
    {
      source: '/:path*',
      destination: '/api/proxy/:path*',
    },
  ],
}

A rewrite to an /api path is not gonna work and it is returning 404 page.

Actual behavior

The current DefaultLambda is not taking in cosideration the manifest of apis, so can not detect if a rewrite is actually leading to a valid API.

Expected behavior

This is working in NextJS and it is actually a good workaround for incremental adoption using a proxy to point everything to the existing legacy system.

Steps to reproduce

Should be enough to create an hello world API under /pages/api and a next.config.js configuration with a rewrite pointing to the API endpoint path.

Versions

• OS/Environment: Manjaro Linux
• @sls-next/serverless-component version:@1.19.0-alpha.35
• Next.js version: v10.0.8-canary.5

Additional context

It is a deal breaker since this was last resort to workaround this issue: https://github.com/serverless-nextjs/serverless-next.js/issues/929

[dphang]

Hm, I’m not quite sure why =/

Anyway I am working on moving API pages to be handled by the default lambda as well so that it’s possible to support cross rewrites. The first PR to consolidate API pages into the default lambda is done here and available in the latest alpha: https://github.com/serverless-nextjs/serverless-next.js/pull/1632 which is experimentally available with build.separateApiLambda = false. (See https://github.com/serverless-nextjs/serverless-next.js/blob/5d6ff2edbf53c0a7e109499d54c7a652ac648dfc/packages/e2e-tests/next-app-experimental/serverless.yml#L8-L8 for an example).

And I just need to rework the rewrite logic. Might be worth investing time there since it’d be the ideal solution…hoping to get it out by end of the week. So maybe you can use the manual solution for some time first.

[dphang]

@alexduros ya I think we just allow behaviors for pages but I think we should just allow all kinds of paths… let me see if that makes sense