Logical ID naming is not following the convention with `-` or `_`

This is a Bug Report

Logical ID naming is not following the convention if lambda function name contains - or _.

Description

With this settings:

service: dash

provider:
  name: aws
  runtime: nodejs6.10

functions:
  photo-resize:
    handler: handler.hello
  photo_recolor:
    handler: handler.hi

sls package produced cloudformation-template-update-stack.json including folloings:

• PhotoDashresizeLambdaFunction
• PhotoDashresizeLambdaVersionPSzzisjnTvvYknuXwQOlAvdkQZ67qXYSvgoAi9T8W0
• PhotoDashresizeLambdaFunctionQualifiedArn
• PhotoUnderscorerecolorLambdaFunction
• PhotoUnderscorerecolorLambdaVersionPSzzisjnTvvYknuXwQOlAvdkQZ67qXYSvgoAi9T8W0
• PhotoUnderscorerecolorLambdaFunctionQualifiedArn

Expected is like:

• PhotoDashResizeLambdaFunction
• PhotoUnderscoreRecolorLambdaFunction

as the document says:

https://github.com/serverless/serverless/blob/master/docs/providers/aws/guide/resources.md#override-aws-cloudformation-resource

This cause trouble when trying to hook S3 event, because we need to overwrite some auto generated resource.

https://github.com/serverless/serverless/blob/master/docs/providers/aws/events/s3.md#custom-bucket-configuration

Related to:

• #2717

Additional Data

  Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           6.10.3
     Serverless Version:     1.23.0

[kayhide]

Hi @HyperBrain, thank you for your quick reply.

Yeah, I understand the situation. I am fine with leaving it as it is, and updating the document.

Just I hope the naming itself is fixed some day 😉

[horike37]

It may add this to v2 milestone if we would change the convention.