Reordering or updating in number of Event Schedules break deployment

This is a Bug Report

Description

After deploying a function with schedules, if the order of the registered schedules change (be it because of actual ordering or because due to additions/removals a schedule with index i became a schedule with index j), further deployments can’t be performed unless the stack or the stuck resources are removed.

I would rather expect that the schedules are order-agnostic and that the deployment would go through despite of the changes in the schedule

The deployment logs are below.

Additional Data

• Serverless Framework Version you’re using: 1.50.0
• Operating System: MacOS Mojave 10.14.5
• Stack Trace:
• Provider Error messages:

Serverless: Packaging service...
Serverless: Excluding development dependencies...
Serverless: Excluding development dependencies...
Serverless: Excluding development dependencies...
Serverless: Uploading CloudFormation file to S3..
Serverless: Uploading artifacts...
Serverless: Uploading service two.zip file to S3 (3.08 MB)...
Serverless: Uploading service one.zip file to S3 (3.08 MB)...
Serverless: Uploading service three.zip file to S3 (3.08 MB)...
Serverless: Validating template...
Serverless: Updating Stack...
Serverless: Checking Stack update progress.
CloudFormation - UPDATE_IN_PROGRESS - AWS::CloudFormation::Stack - project-production
CloudFormation - UPDATE_IN_PROGRESS - AWS::Lambda::Function - TwoLambdaFunction
CloudFormation - UPDATE_IN_PROGRESS - AWS::Lambda::Function - OneLambdaFunction
CloudFormation - UPDATE_IN_PROGRESS - AWS::Lambda::Function - ThreeLambdaFunction
CloudFormation - UPDATE_COMPLETE - AWS::Lambda::Function - TwoLambdaFunction
CloudFormation - UPDATE_COMPLETE - AWS::Lambda::Function - ThreeLambdaFunction
CloudFormation - UPDATE_COMPLETE - AWS::Lambda::Function - OneLambdaFunction
CloudFormation - CREATE_IN_PROGRESS - AWS::Lambda::Version - TwoLambdaVersionWd3JK80dXWmbHhVFGMrJccCAx5Kodao3jGJQ5Lb8Ek
CloudFormation - CREATE_IN_PROGRESS - AWS::Lambda::Version - ThreeLambdaVersionCvqOmcZL1XCCCxef4Kk2CcJ3ok5xaFAY9WAo04XG0
CloudFormation - CREATE_IN_PROGRESS - AWS::Lambda::Version - OneLambdaVersionf1R6UE7K9gussctXIuRUWqvguba3OmqTRUTHn7FWM
CloudFormation - CREATE_IN_PROGRESS - AWS::Lambda::Version - TwoLambdaVersionWd3JK80dXWmbHhVFGMrJccCAx5Kodao3jGJQ5Lb8Ek
CloudFormation - CREATE_COMPLETE - AWS::Lambda::Version - TwoLambdaVersionWd3JK80dXWmbHhVFGMrJccCAx5Kodao3jGJQ5Lb8Ek
CloudFormation - CREATE_IN_PROGRESS - AWS::Lambda::Version - ThreeLambdaVersionCvqOmcZL1XCCCxef4Kk2CcJ3ok5xaFAY9WAo04XG0
CloudFormation - CREATE_IN_PROGRESS - AWS::Lambda::Version - OneLambdaVersionf1R6UE7K9gussctXIuRUWqvguba3OmqTRUTHn7FWM
CloudFormation - CREATE_COMPLETE - AWS::Lambda::Version - ThreeLambdaVersionCvqOmcZL1XCCCxef4Kk2CcJ3ok5xaFAY9WAo04XG0
CloudFormation - CREATE_COMPLETE - AWS::Lambda::Version - OneLambdaVersionf1R6UE7K9gussctXIuRUWqvguba3OmqTRUTHn7FWM
CloudFormation - UPDATE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule6
CloudFormation - UPDATE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule5
CloudFormation - UPDATE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule3
CloudFormation - UPDATE_FAILED - AWS::Events::Rule - OneEventsRuleSchedule6
CloudFormation - UPDATE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule7
CloudFormation - UPDATE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule4
CloudFormation - UPDATE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule1
CloudFormation - UPDATE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule2
CloudFormation - UPDATE_FAILED - AWS::Events::Rule - OneEventsRuleSchedule3
CloudFormation - UPDATE_FAILED - AWS::Events::Rule - OneEventsRuleSchedule5
CloudFormation - UPDATE_FAILED - AWS::Events::Rule - OneEventsRuleSchedule2
CloudFormation - UPDATE_FAILED - AWS::Events::Rule - OneEventsRuleSchedule1
CloudFormation - UPDATE_FAILED - AWS::Events::Rule - OneEventsRuleSchedule4
CloudFormation - UPDATE_FAILED - AWS::Events::Rule - OneEventsRuleSchedule7
CloudFormation - UPDATE_ROLLBACK_IN_PROGRESS - AWS::CloudFormation::Stack - project-production
CloudFormation - UPDATE_IN_PROGRESS - AWS::Lambda::Function - OneLambdaFunction
CloudFormation - UPDATE_IN_PROGRESS - AWS::Lambda::Function - ThreeLambdaFunction
CloudFormation - UPDATE_IN_PROGRESS - AWS::Lambda::Function - TwoLambdaFunction
CloudFormation - UPDATE_COMPLETE - AWS::Lambda::Function - TwoLambdaFunction
CloudFormation - UPDATE_COMPLETE - AWS::Lambda::Function - ThreeLambdaFunction
CloudFormation - UPDATE_COMPLETE - AWS::Lambda::Function - OneLambdaFunction
CloudFormation - UPDATE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule5
CloudFormation - UPDATE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule6
CloudFormation - UPDATE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule2
CloudFormation - UPDATE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule1
CloudFormation - UPDATE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule3
CloudFormation - UPDATE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule7
CloudFormation - UPDATE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule4
CloudFormation - UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS - AWS::CloudFormation::Stack - project-production
CloudFormation - DELETE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule6
CloudFormation - DELETE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule3
CloudFormation - DELETE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule5
CloudFormation - DELETE_IN_PROGRESS - AWS::Events::Rule - OneEventsRuleSchedule7
CloudFormation - DELETE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule1
CloudFormation - DELETE_SKIPPED - AWS::Lambda::Version - ThreeLambdaVersionCvqOmcZL1XCCCxef4Kk2CcJ3ok5xaFAY9WAo04XG0
CloudFormation - DELETE_SKIPPED - AWS::Lambda::Version - OneLambdaVersionf1R6UE7K9gussctXIuRUWqvguba3OmqTRUTHn7FWM
CloudFormation - DELETE_SKIPPED - AWS::Lambda::Version - TwoLambdaVersionWd3JK80dXWmbHhVFGMrJccCAx5Kodao3jGJQ5Lb8Ek
CloudFormation - DELETE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule4
CloudFormation - DELETE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule2
CloudFormation - DELETE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule3
CloudFormation - DELETE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule5
CloudFormation - DELETE_COMPLETE - AWS::Events::Rule - OneEventsRuleSchedule7
CloudFormation - UPDATE_ROLLBACK_COMPLETE - AWS::CloudFormation::Stack - project-production
Serverless: Operation failed!
Serverless: View the full error output: 

[medikoo]

@medikoo we ran into this a couple of times over the past few months. Do you mean that if we don’t set a name on the schedules we won’t run into this issue?

Yes

[araujoigor]

@gnomeria Thank you very much! I completely forgot I opened this issue (even had a local branch with the solution).

I like your solution, and it is pretty similar to what I had in mind.

I would love to have this merged and am looking forward to it 😃