'sls remove' fails when S3 bucket contains objects

For a given Serverless service where an S3 bucket has been created via the CloudFormation stack and some objects have been put in said bucket, running sls remove fails to succeed because the buckets will not delete unless empty.

I believe the same process used to empty the deployment buckets should also be applied to any buckets created through CloudFormation.

What I’m not sure of is whether this should be implemented in core or relegated to a plugin.

• Serverless Framework Version you’re using: 1.17

---

Proposed solution (added later by maintainers)

• Introduce provider.shouldEmptyBucketsOnRemove config option, and --empty-s3-buckets CLI param. If it’s on, removal process prior removing stack on CloudFormation should first find all S3 buckets (aside of deployment one) in a stack to be removed (we should rely on template downloaded from AWS, and not one generated by Framework), and empty them.
• If none of the above is not set, and removal fails with bucket not empty error, then present meaningful error message suggesting above options

⚠️ ⚠️ ⚠️ If you’d like to address that, but you’re not sure how to tackle this, please ask for help, we’ll provide a specific implementation spec you can follow!

[horike37]

--force option would be nice! +1

[pmuens]

Thanks for opening @ryanmurakami and thanks @horike37 for jumping in 👍

I believe the same process used to empty the deployment buckets should also be applied to any buckets created through CloudFormation.

We’ve discussed a related feature in https://github.com/serverless/serverless/issues/3679 and https://github.com/serverless/serverless/issues/1609.

IMHO Serverless shouldn’t auto-remove something for you since the bucket can contain some important data (same for DynamoDB and other services). However the --force option could be smth. we can add so that the user has to explicitly state that he wants to remove everything.