Tests: Refactor lib/plugins/aws/package/compile/functions/index.test.js

Most of the tests that currently cover core functionalities depend heavily on (and sometimes test) internal implementation characteristics. While they should be testing whether given implementation produces desired outcome (treating its implementation more as a black box).

Current state of things is problematic for eventual internal improvements and refactors which occasionally we want to introduce, as in most of such cases proposed improvements need to be accompanied with counterproductive numerous updates to tests which are covering otherwise not altered functionalities .

_At some point we’ve introduced a new (black box based) way of testing the internals. It’s through runServerless utlity, which allows us create natural (as in real world) serverless instance, and inspect the produced outcome for chosen command. More details here: https://github.com/serverless/serverless/tree/master/test#unit-tests_

---

This is issue is about refactoring lib/plugins/aws/package/compile/functions/index.test.js to runServerless based variant.

It’s needed, so we cleanly move forward with https://github.com/serverless/serverless/issues/8396

To make refactor relatively easy:

• Spec for new tests is fully defined and is already committed in. It’s in scope of this describe block: https://github.com/serverless/serverless/blob/aa42b3bb899b1b770aeea013b51a4a3f2916427e/lib/plugins/aws/package/compile/functions/index.test.js#L2366
• Each test slot indicates which test it is about to replace
• It is indicated where (and how many) exactly runServerless runs are expected to happen, against which fixture and command they should be based
• Necessary hints are provided

For every refactored test, the old test should be removed

As this test file is large, let’s divide work into following parts (best if each part is addressed with individual PR):

• Provider properties: (Addressed with https://github.com/serverless/serverless/pull/8623) https://github.com/serverless/serverless/blob/aa42b3bb899b1b770aeea013b51a4a3f2916427e/lib/plugins/aws/package/compile/functions/index.test.js#L2403-L2511
• Provider role variants: https://github.com/serverless/serverless/blob/aa42b3bb899b1b770aeea013b51a4a3f2916427e/lib/plugins/aws/package/compile/functions/index.test.js#L2536-L2552
• Function properties: https://github.com/serverless/serverless/blob/aa42b3bb899b1b770aeea013b51a4a3f2916427e/lib/plugins/aws/package/compile/functions/index.test.js#L2610-L2790
• Version hash resolution: https://github.com/serverless/serverless/blob/aa42b3bb899b1b770aeea013b51a4a3f2916427e/lib/plugins/aws/package/compile/functions/index.test.js#L2923-L2928
• Download package artifact from S3 bucket: https://github.com/serverless/serverless/blob/aa42b3bb899b1b770aeea013b51a4a3f2916427e/lib/plugins/aws/package/compile/functions/index.test.js#L3159-L3182

[sdas13]

Thanks @pgrzesik I will keep an eye on the v3 release

[pgrzesik]

Thanks for being vigilant and letting me know about it @issea1015 🙇