608 Captions Data is not captured in HLS, Live
See original GitHub issueHave you read the FAQ and checked for duplicate open issues? Yes
What version of Shaka Player are you using? v2.5.2
Can you reproduce the issue with our latest release version? Yes (v2.5.9)
Can you reproduce the issue with the latest code from master
?
Yes
Are you using the demo app or your own custom app? Demo app
If custom app, can you reproduce the issue using our demo app? N/A
What browser and OS are you using? Google Chrome v80.0.3987.149 (Official Build) (64-bit), macOS Mojave 10.14.6
For embedded devices (smart TVs, etc.), what model and firmware version are you using? N/A
What are the manifest and license server URIs? The URL doesn’t have long TTL, if necessary, I could provide it separately.
What did you do? Copied the manifest URL, did setup the custom content in the Demo application, click play if it does not autoplay.
What did you expect to happen? I see the captions menu with the ability to select from or turn them off.
What actually happened? Embedded Captions doesn’t work, there is no option to select the captions in Demo application.
Looks like Media Source Engine pumps data to the Text Engine
. I was able to identify that mux.js parses caption data from the stream. But in the text engine there is a compromised comparison for identifiers. Also, it impacts the Streaming Engine
update routine where the MIME type for embedded captions is not explicitly supported.
Issue Analytics
- State:
- Created 3 years ago
- Comments:10 (5 by maintainers)
Top GitHub Comments
@arturparkhisenko , thank you for providing the manifest!
For captions embedded in the video, f the playlist doesn’t contain CLOSED-CAPTIONS metadata, we can’t know if there’s captions or not until the video starts playing and the data gets transmuxed. Thus, we might not be able to show the captions on/off options in the menu. If you have a manifest with CLOSED-CAPTIONS attributes in the playlist, it’s expected to see the captions options displayed in the menu.
If you want us to detect and display embedded closed captions data on-the-fly, that might be the same issue as https://github.com/google/shaka-player/issues/1826 .
Hello @arturparkhisenko ,