XLSX.stream.to_json doesn't ends when a blank row is the last row in Excel sheet.

sheetjs/bits/97_node.js

		stream._read = function() {
 			if(R > r.e.r) return stream.push(null);
			while(R <= r.e.r) {
				//if ((rowinfo[R-1]||{}).hidden) continue;
				var row = make_json_row(sheet, r, R, cols, header, hdr, dense, o);
				++R;
				if((row.isempty === false) || (header === 1 ? o.blankrows !== false : !!o.blankrows)) {
					stream.push(row.row);
					break;
				}
			}
		};
		return stream;

Hi @SheetJSDev !

This piece of code has the R > r.e.r checking outside of the loop but when a blank row is inserted at the end of a given sheet then the if((row.isempty === false) || (header === 1 ? o.blankrows !== false : !!o.blankrows)) condition inside of the while loop isn’t executed and the stream does not end.

Ill be submitting a pull request for the same for a fix for this issue that I have found. Please verify and merge the changes as soon as possible as I am using this library in production in my system.

[mpgo13]

I’m having the same issue. I noticed that setting blankrows: true will emit the end event. Here my reproducible problem:

const xlsx = require('xlsx');
const workbook = xlsx.utils.book_new();
const worksheet = xlsx.utils.json_to_sheet([
  {
    a: '1',
    b: '2',
  },
  {},
  {
    a: '11',
    b: '22',
  },
  {},
  {},
]);
xlsx.utils.book_append_sheet(workbook, worksheet);

const stream = xlsx.stream.to_json(workbook.Sheets[workbook.SheetNames[0]], {
  //blankrows: true, // WORKS with blankrows = true
  header: ['a', 'b'],
});

let closed = false;

stream.on('data', console.log);
stream.on('close', () => console.log('CLOSE'));
stream.on('end', err => {
  console.log('END', err);

  closed = true;
});

// for the event loop
const interval = setInterval(() => {
  if (closed) {
    clearInterval(interval);
  }
}, 100);

[highflying]

@highflying can you please elaborate more when you say “specify the range to skip processing the blank lines”

I know the range of the sheet that has data in it, so I am specifying it manually, e.g.

  const stream = XLSX.stream.to_json(sheet, {
    range: "A1:BN3",
  });

When doing this the end event gets emitted, without it no end event happens.