Screenshots/Videos do not upload when setting `allureWriter(on, config);` before `after:spec`

Describe the bug Cypress screenshots and videos do not upload to the Allure test report when setting allureWriter(on, config); before on('after:spec', () in /cypress/plugins/index.ts.

  allureWriter(on, config);

  on('after:spec', (spec: { name: string }, results: { video: boolean; tests: number }) => {
    // Send test metrics to Datadog after:spec as after:run results in the final metric sometimes not getting sent
    if (process.env.BUILDKITE) {
      reportSpecTestMetrics(spec);
    }

    if (results && results.video) {
      // Do we have failures for any retry attempts?
      const failures = _.some(results.tests, (test: { attempts: number }) => {
        return _.some(test.attempts, { state: 'failed' });
      });
      if (!failures) {
        // Delete the video if the spec passed and no tests retried
        return del(results.video);
      }
    }
  });

To Reproduce Steps to reproduce the behavior:

1. Set allureWriter(on, config); before on('after:spec', () in /cypress/plugins/index.ts

Expected behavior When allureWriter(on, config); is set after after:spec, the screenshots/videos get uploaded to the report. Placing it before after:spec does not upload screenshots/videos.

Environment (please complete the following information):

• Cypress version: 9.0.0
• OS: Mac

** Developer Tools Console Output **

Additional context Add any other context about the problem here.

[willischu]

@Shelex the fix looks good!! thank you again.

[willischu]

@Shelex, awesome - yes, will test it shortly. thank you