adjust minimum height/width constraints for smaller screen sizes
See original GitHub issueDescription
I believe the minimum height is too large for my setup and causes the GitHub Desktop to open up with maximum height on the wrong monitor.
Version
- GitHub Desktop: 1.4.0-linux2 (also happened on 1.3.x and earlier) snap
- Operating system: Ubuntu 16.04 with Xfce 4.12
Steps to Reproduce
Open GitHub desktop on Ubuntu 16.04 Xfce 4.12 with a 768p screen with a 48 pixel tall bottom panel/bar/dock and a 30 pixel tall top panel/bar/dock (whatever you want to call it)
It now opens on my second monitor (a 1080p screen)
Expected Behavior
I expect it to open minimum size for height and width as it does on two 1080p monitors.
Actual Behavior
The minimum height of GitHub desktop is too large. Is there any way to decrease the minimum height - even if just for the Linux port, or maybe upstream? Or, perhaps fixing it so that it opens with the correct minimum height on my second monitor? I am not sure if this issue belongs upstream or in the Linux port.
Keep in mind, when I launch GitHub desktop with my mouse on my second (1080p) screen, the minimum height and width are what they should be - it is only when I keep my mouse on my primary (768p) screen that the height becomes maximum.
Sorry for my very strange use-case, but, these things happen in life.
Here are some (horizontally cropped to redact info) pictures that show what I am talking about.
Here is an example of the issue I am talking about:
Here is what it should look like:
Notice the 713px height instead of the 1080px height.
Issue Analytics
- State:
- Created 5 years ago
- Comments:12 (2 by maintainers)
Top GitHub Comments
I think we should just omit this line https://github.com/shiftkey/desktop/blob/6621825c3de8f6edff4f68574ce3658a6e48c91e/app/src/main-process/app-window.ts#L43 it will still launch with a height of
660
, but users are at least able to resize the window to something that fits their screen (right now its 660 and not resizable).As another use case that is currently being prevented by the sizing being what it is, it’s difficult to use the app on a MacBook Pro 13" with effective resolution of 1680x1050; I would prefer to have my screen split to left and right halves, meaning I would want GitHub Desktop to be 840 pixels wide, which is prevented by the current configuration.