GNOME terminal not always present when using "Open in Shell" for first time

Describe the bug

Can’t open repository folder in terminal on Deepin DE (also fails on Deepin OS distro)

Version & OS

Github Desktop Version: 2.5.4-linux1 OS: Arch Linux x64 - kernel version: 5.8.8-arch1-1

Steps to reproduce the behavior

1. Open a local repository
2. Go to Repository menu
3. Click on ‘Open in GNOME(?) Terminal’ menu item (no GNOME installed)
4. Bang! Error message shown

Expected behavior

System’s default Virtual Terminal Emulator (Deepin Terminal, in my case) started on repository folder

Actual behavior

This message:

Screenshots

Compared to referenced issue #167 , Deepin Terminal finally appears in shell menu

Logs

2020-09-16T17:11:11.064Z - info: [ui] Background fetch for 10 repositories took 1.321sec
2020-09-16T17:17:31.709Z - info: [ui] [AppStore] loading 10 repositories from store
2020-09-16T17:17:31.709Z - info: [ui] [AppStore] found account: jmejia32 (Javier Mejía Estrada)
2020-09-16T17:17:32.253Z - info: [ui] launching: 2.5.4-linux1 (Linux 5.8.8-arch1-1)
2020-09-16T17:17:32.254Z - info: [ui] execPath: '/opt/github-desktop/github-desktop'
2020-09-16T17:19:21.527Z - info: [ui] [AppStore] loading 9 repositories from store
2020-09-16T17:19:21.527Z - info: [ui] [AppStore] found account: jmejia32 (Javier Mejía Estrada)
2020-09-16T17:19:22.070Z - info: [ui] launching: 2.5.4-linux1 (Linux 5.8.8-arch1-1)
2020-09-16T17:19:22.071Z - info: [ui] execPath: '/opt/github-desktop/github-desktop'

[shiftkey]

“GNOME Terminal” is shown regardless it is installed or not, and Deepin Terminal works so far.

There’s some history in here that I’m hazy on, but on initial launch we don’t have a selected terminal and the placeholder we use is a best guess. This works fine on Windows and macOS because we know what shells are available by default, but clearly that won’t work for Linux due to the different permutations of configurations available.

It’d be nice to be able to probe on this first launch and see what shells are installed, and choose the first valid shell, but I’m not sure if we have a suitable hook to do that.

[aminya]

I have the same problem. On Kubuntu, the default terminal is the Konsole, but the “Open in <Terminal>” UI still shows the GNOME terminal, which doesn’t work; giving a path error. KDE doesn’t come with a GNOME terminal.

The workaround seems to be going into the setting and manually setting the integrations to Konsole.

I think the default terminal detection logic should be improved. Checking more famous terminal apps by default and skipping those that are not installed.