KDE uses generic "desktop" icon rather than GitHubDesktop icon

Description

Admittedly, this is a very minor issue, and I’d like to say thanks for your work on this!

KDE uses a generic “Desktop” icon in the launcher rather than the GitHubDesktop icon. This is some combination of #22 and KDE confusing the two icons. I was not able to change it via the Edit Applications... menu until I renamed the icons github-desktop.png (see below for more detail). The correct icon is used elsewhere, so this is not a duplicate of #16

Version

• GitHub Desktop: 1.1.1 Linux RC

• Operating system: Kubuntu 17.10

• KDE Plasma 5.10.5

Steps to Reproduce

1. Install GitHubDesktop via most recent .deb
2. Open launcher
3. Find GitHubDesktop entry (generic “Desktop” icon displayed)
4. Right click launcher > Edit Applications… > Development > GitHubDesktop
5. Click icon to change > choose desktop icon that matches GitHubDesktop
6. Exit > Save
7. Repeat steps 2-3

Expected Behavior

Find GitHubDesktop in launcher, see GitHubDesktop icon.

Actual Behavior

GitHubDesktop icon is generic “desktop” icon, can’t be changed via KDE Menu Editor.

Workaround

1. Rename icons desktop.png to github-desktop.png

sudo mv /usr/share/icons/hicolor/1024x1024/apps/desktop.png /usr/share/icons/hicolor/1024x1024/apps/github-desktop.png
sudo mv /usr/share/icons/hicolor/512x512/apps/desktop.png /usr/share/icons/hicolor/512x512/apps/github-desktop.png
sudo mv /usr/share/icons/hicolor/256x256/apps/desktop.png /usr/share/icons/hicolor/256x256/apps/github-desktop.png

1. Right click launcher > Edit Applications… > Development > GitHubDesktop
2. Click icon to change > choose github-desktop icon that matches GitHubDesktop
3. Exit > Save

[shiftkey]

Rename icons desktop.png to github-desktop.png

I’m aiming to get #80 in for the 1.5.0 release, which renames the package from desktop to github-desktop, and will update these files to use a name:

[Raymo111]

Thanks @shiftkey 🙂