ShopifyResource.find does not propagate kwargs to PaginatedCollection

Hey folks, I’m testing the new pagination and I’ve found that resource.find(no_iter_next=True) doesn’t work as expected (e.g. the resulting iterator will still fetch additional pages).

After having a quick look through the source code, it appears that this is because the kwargs are never passed through: https://github.com/Shopify/shopify_python_api/blob/master/shopify/base.py#L213

Overriding the variable on the collection works fine, but is non-ideal:

        collection = resource.find(**kwargs)
        collection._no_iter_next = True

[UnicycleJonathan]

It’s important that no_iter_next be the default behavior here, and only allow automatic iteration of subsequent pages if the caller has explicitly asked for that via a parameter. Otherwise, this isn’t backwards compatible and will likely introduce a lot of serious bugs and runaway code for people who are upgrading.

As mentioned above, existing code that does implicit iteration via for order in shopify.Order.find(limit=5): is expecting to iterate over at most 5 orders, but with the new behavior this will iterate over all orders in the entire shop.

This will likely break almost every Python client so it’s important to invert the default behavior.

[tanema]

Okay, I have changed my Pr to make no_iter_next to default to True. I will release this tonight so that you can use this and it will be easier to use. I will be a breaking release in case anyone has built on top of the current behaviour