question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Show "in progress" status in PRs?

See original GitHub issue

Right now I see the bundlesize report only when the PR is completed. I’d love to see it in “yellow” while the build is still proceeding.

Maybe add a bundlesize start command to run before any other build command to notify the PR about this check?

The test script would look like this:

"scripts": {
  // better command names are welcome 🙄
  "test": "bundlesize start && jest && bundlesize check"
}

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:5
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
siddharthkpcommented, Jul 1, 2017

Yep, I totally get that.

Tell you what, I’ll add it if > 5 people want it. That’s fair? 😄

1reaction
FezVrastacommented, Jul 1, 2017

I see what you mean, but the thing is that if I run bundlesize before I run my tests & build, it will never find the bundle file.

So my test script is:

"test": "lerna run --parallel test && npm run build && bundlesize",

Because I first run the tests, then I create a build and then bundlesize can read the size of it.

While I wait for test and build to complete, there’s not a bundlesize “in progress” badge

Read more comments on GitHub >

github_iconTop Results From Across the Web

PRS User's Guide - ClinicalTrials.gov
Record status​​ As a record progresses through the PRS, its status changes, as described in Table 1. User is creating (or modifying) the...
Read more >
Linked PRs show incorrect status - Atlassian Community
Our process is to link Github PRs to cards before assigning them to a reviewer. PRs usefully show the status of checks, but...
Read more >
About status checks - GitHub Docs
Status checks let you know if your commits meet the conditions set for the repository you're contributing to. Status checks are based on...
Read more >
Reporting live performances - PRS for Music
You can report live performances for all sizes of venue, from gigs to concerts. For each, we have a time limit on accepting...
Read more >
Introducing draft pull requests - The GitHub Blog
Tag your work in progress ... Change the status to “Ready for review” near the bottom of your pull request to remove the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found