Support github integration for PRs from forks

@siddharthkp Nice work in creating bundlesize! We’re using it to keep track of our binary sizes on the AMP project (https://github.com/ampproject/amphtml).

I was trying to make full use of PR integration using BUNDLESIZE_GITHUB_TOKEN as described here, but reached an impasse because Travis does not make secure tokens available to incoming pull requests from forks, and all incoming PRs on ampproject/amphtml come from forks.

Is there a way to approve bundlesize for GitHub PR status integration without having to make a token available in the Travis environment? I’ve successfully done so for other tools like Percy and LGTM.com, and this works for incoming PRs from forks. I was hoping something like this can be done with bundlesize.

[sj]

Hi @siddharthkp and @rsimha! Indeed, LGTM works through GitHub webhooks (full disclosure: I’m on the team).

I’ve just added bundlesize to LGTM.com for JavaScript analysis, so you can see how the integration works. The code analysis results are available here, but… There are zero alerts! Great stuff.

At this stage no GitHub integration has been set up between LGTM and bundlesize, but if you wanted to enable automatic code review in pull requests, it’s easy to set up by going here: https://lgtm.com/projects/g/siddharthkp/bundlesize/ci/. It’ll redirect you to GitHub to make sure that you’re happy to give LGTM permissions to comment on your PR, and you’re done. It shouldn’t be difficult to set something similar up for bundlesize, I think.

Let me know if you’d like to know more about how this was set up and how you could do something similar for bundlesize; I can always put you in touch with one of my colleagues.

[rsimha]

@siddharthkp I believe they registered as GitHub apps, so the permission is granted through the API and not through a token.

See https://developer.github.com/apps/building-github-apps/