Date type and 0000-01-01

Hi,

I have a date field in MySQL table with 0000-01-01 default value. In MySQL it stores correctly, but when I execute a select query I get ‘1900-01-01T00:00:00.000Z’ value.

I think this a bug, because 0000 != 1900. I’m using this field for user birthday and age calculating. So when I’m trying to calculate a user age I get 118 years old. I handle zero values in my app and I think I should not handle 1900 value.

Thanks

[nanom1t]

It works with dateStrings: true. Thank you!

[sidorares]

Works as expected when I pass dateStrings: true ( sorry in my first comment I said it should be “false”. Meaning of that flag is “don’t try to construct js Date and just return the string as it’s stored”

[ TextRow { birthday: '0000-01-01' },
  TextRow { birthday: '0000-01-01' },
  TextRow { birthday: '0000-01-01' },
  TextRow { birthday: '0000-01-01' } ]

When dateStrings is not set resulting date is built here: https://github.com/sidorares/node-mysql2/blob/0da580e52c3ae37832c8fde49dddd56fb88aa52b/lib/packets/packet.js#L541

return new Date(y, m - 1, d); - in your case y is 0, m is 1 and d is 1. I’d say 1900-01-01T00:00:00.000Z is also expected in this case, that’s the way js Date constructor interprets years