Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

error while parsing: "should not reach here"

See original GitHub issue

~Snip stack:

    at Packet.readLengthCodedNumberExt (/node_modules/mysql2/lib/packets/packet.js:207:11)
    at Packet.readLengthCodedNumber (/node_modules/mysql2/lib/packets/packet.js:157:15)
    at Packet.parseLengthCodedInt (/node_modules/mysql2/lib/packets/packet.js:668:29)

I can’t tell exactly what the problem is, but it seems like there’s no bounds check on the Packet.readLengthCodedNumber function.

https://github.com/sidorares/node-mysql2/blob/b098d4969a000644d110e29b9aa0bee33cb1dfcb/lib/packets/packet.js#L152-L158

if offset is greater than buffer’s length, then byte2 is set to undefined, which breaks the rest of the code.

Issue Analytics

State:
Created 6 years ago
Comments:7 (3 by maintainers)

Top GitHub Comments

1reaction

bradzachercommented, Oct 24, 2017

upon inspection - it seems like it occurs if you call one of the conversion functions (string/buffer/geometry) more than once for a field.

If you call one a second time then it essentially triggers the buffer read again without resetting the offset, which screws up the offset for future fields.

There should be handling in place this to prevent it (or an error message).

0reactions

hcd660commented, Aug 1, 2022

use mysql 5.7