how to bluebird promisifyAll mysql2

Hello, I’m in the process of converting my current implementation of node-mysql driver to mysql2 and fully utilize promises (bluebird). i figured the upgrade to mysql 2 should be a simple matter of changing ‘mysql’ to ‘mysql2’ but i am getting some errors and figured i’d ask for some help.

currently i have this setup for node-mysql

const Promise = require('bluebird');
const mysql = require('mysql');
const Pool = require('mysql/lib/Pool');
const options = { ... };
const Connection = require('mysql/lib/Connection');
Promise.promisifyAll([Pool, Connection]);
const pool = mysql.createPool(options);
module.exports = pool;

i tried

Promise.promisifyAll(require('mysql2'));

i also tried

const Promise = require('bluebird');
const mysql = require('mysql2');
const Pool = require('mysql2/lib/Pool');
const Connection = require('mysql2/lib/Connection');
Promise.promisifyAll([Pool, Connection]);
const options = { ... };
const pool = mysql.createPool(options);
module.exports = pool;

both gives me the error below.

TypeError: pool.getConnectionAsync is not a function

so the question is, how do i promisifyAll this module? Any help would be great, thanks!

[thewillhuang]

working version

'use strict';

const Promise = require('bluebird');
const mysql = require('mysql2');
const options = { ... };
const Pool = require('mysql2/lib/pool');
const Connection = require('mysql2/lib/connection');
Promise.promisifyAll([Pool, Connection]);
// long stack trace for debug
Promise.longStackTraces();
const pool = mysql.createPool(options);
module.exports = pool;

on top of that, my tests now run faster

before

    ✓ the deleted facility should not exist (130ms)
    ✓ the deleted user should not exist (127ms)


  375 passing (60s)

now

    ✓ the deleted facility should not exist (66ms)
    ✓ the deleted user should not exist (66ms)


  375 passing (36s)

yay for more speed

[sidorares]

Hi!

I’m trying to keep file names lower case, and path to pool is /lib/pool.js, so you should be able to do

const mysql = require('mysql2');
const Pool = require('mysql2/lib/pool');
const Connection = mysql.Connection; // I should probably export mysql.Pool same way - see https://github.com/sidorares/node-mysql2/blob/master/index.js#L11