support key value object place holder

please support something like

p.execute("INSERT INTO chat_alert_item SET ?", {col1: value1, col2: value2});

you can see similar example in the documentation of npm mysql

var post  = {id: 1, title: 'Hello MySQL'};
var query = connection.query('INSERT INTO posts SET ?', post, function (error, results, fields) {
  if (error) throw error;
  // Neat!
});
console.log(query.sql); // INSERT INTO posts SET `id` = 1, `title` = 'Hello MySQL'

currently in your implementation it gives

    at PoolConnection.execute (/usr/src/app/node_modules/mysql2/lib/connection.js:688:20)
    at /usr/src/app/node_modules/mysql2/lib/pool.js:180:29
    at /usr/src/app/node_modules/mysql2/lib/pool.js:36:14
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)

[muayyad-alsadi]

thank you for your suggestion

but from the readme of this project

MySQL2 project is a continuation of MySQL-Native… and api changed to match popular mysqljs/mysql. MySQL2 is mostly API compatible with Node MySQL. You should check their API documentation to see all available API options. If you find any incompatibility with Node MySQL, Please report via Issue tracker. We will fix reported incompatibility on priority basis.

this means if it works in mysqljs/mysql it should work here. the code snippet is from their readme, it’s not only a valid use case, but it’s by the book.

just use .query()

isn’t .query is for select, while .execute for updates/insert?

use format + execute: p.execute(mysql.format(“INSERT INTO chat_alert_item SET ?”, {col1: value1, col2: value2}))

then it p.execute() should use mysql.format internally

expand manually ( preferred way, maybe we should add helper to automate this?)

yes, this is what I did

let cols = Object.keys(row).join('=?, ')+'=?';
pool.execute("INSERT INTO chat_alert_item SET "+cols, Object.values(row));

[sidorares]

should be safe, see https://github.com/sidorares/node-mysql2/issues/553#issuecomment-437221838