metric.remove potentially broken
See original GitHub issueFirst of all: Nice work! prom-client
is my go-to prometheus exporter lib for node-based services! ❤
I think the metric.remove
method added in #242 needs to be reworked because there is no safe way to hand over multiple label/value pairs. Or maybe I’m missing something.
Given a gauge metric, that I used to track this value:
metric.set({
first: "foo",
second: "bar",
}, 1337)
I call metric.remove("foo", "bar")
and I have to rely on js object-key ordering, which works in V8, but is not guaranteed in the language spec.
What I’d like to call is:
metric.remove({
first: "foo",
second: "bar",
});
Edit: Formatting
Issue Analytics
- State:
- Created 4 years ago
- Reactions:3
- Comments:8 (2 by maintainers)
Top Results From Across the Web
Using metrics to remove bottlenecks and support your team
Teams that use metrics to pinpoint and remove bottlenecks and slowdowns are ultimately more efficient, more productive, and happier.
Read more >In Prometheus, is there a way to detect if a particular metric ...
In Prometheus, is there a way to detect if a particular metric stops being emitted broken down by host using just one query?...
Read more >Improve Performance by removing 20 metric tons of broken ...
Step 7. Click the "Replace in Files" Button, and wait for NP++ to finish up. That's it! Disclaimer: This will delete all glass...
Read more >Schema checks - Apollo GraphQL Docs
Potentially breaking changes. Removals. These changes remove a schema element. If a removed element is actively being used by an operation, that operation...
Read more >Instrumentation - Prometheus.io
Every library, subsystem and service should have at least a few metrics to ... For monitoring purposes, services can generally be broken down...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
i guess so: https://github.com/siimon/prom-client/commit/3a86d05c49addc8294e9dcf16600226d6b970385
closing this
uh uh… i was not assigned and totally forgot about this one. will tackle it in the next weeks