[v2.0.6] iOS: crashes on https downloadFile() call

I realise that I may not be providing sufficient context and data, however I can positively state that up to v2.0.5 my app works flawless using several https:// downloadFile() calls.

After updating, the app immediately crashes on the first downloadFile() call.

Going back to v2.0.5 fixes this and it works as expected.

Here is as far as I can document the issue, an xcode debug screenshot after crashing:

[silkimen]

Ok, I see. Seems to be a race condition issue. I’ll try to write a test case for this special case to find a working fix. But you’re right, for the first instance, I’ll need to revert this commit.

[chrisjdev]

I finally reproduced this issue by changing my code to use downloadFile(). I’m not sure what it’s for, but there’s a manager.responseSerializer = [SM_AFHTTPResponseSerializer serializer]; line in downloadFile(). I have no other calls to set the response serializer, and for whatever reason, that serializer returns an NSData* instead of a NSString*. When an uploadFile() call runs after a call to downloadFile(), it throws an exception because it can’t serialize NSData to JSON. It also appears to be opening a new socket for downloadFile(). I’m still looking into why that might be happening, but one workaround might be to remove the line that sets the responseSerializer, or add a new member variable for a SM_AFHTTPSessionManager that’s used only for downloadFile().