works with "any HTTP client library" doesn't seem to be true

I might be misunderstanding something, but when I tried to use my HTTP client library of choice (superagent) Purest hung indefinitely until I exited the process.

This works:

const request = require('request');
const purest = require('purest')({ request, promise: Promise });

This doesn’t work:

const request = require('superagent');
const purest = require('purest')({ request, promise: Promise });

[simov]

Hi @bitinn, Grant uses request-compose under the hood. It’s my latest (and greatest) HTTP client for Node.

It’s not exactly a rewrite of request and that have never been the goal, even though the multipart, oauth and cookie ‘middlewares’ are taken straight from request. They were initially extracted out for my actual rewrite, @request/core, a few years ago. request-logs is taken from @request/log initially implemented for @request/core.

It’s possible to add request-compose as optional HTTP client here, unfortunately it can’t be set as default one without major release, because it have some differences with request, namely it’s not a duplex stream, and also it doesn’t implement the @request/interface strictly. And this is going to be yet another breaking change and not fully backward compatible version.

[simov]

I agree, though I don’t think it was intentional.

I guess I got a bit carried out with the use of the word any because it’s certainly true for Promise implementations and REST APIs, but not so much for HTTP clients apparently.

Probably I had the intention to create those wrappers, can’t tell you for sure. Currently only request and @request/client fully implement the interface. @request/core was my attempt to rewrite request long time ago, and it was covering the entire request test suit at that time, so it’s pretty stable and feature rich as it is. I always pair it with Purest, however the code base suffers from other issues and I can’t recommend using it because no one is maintaining it. You can try it out of course and see if it works for you as it is.

Anyway, thanks for your feedback! I’m going to update the readme and phrase it more correctly. 👍