Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Python 3.5 Support???

See original GitHub issue

The docs imply discretize still supports Python 3.5 (see this) yet there are f-strings (F-strings were introduced in Python 3.6) in:

https://github.com/simpeg/discretize/blob/a4ead91d6a1f84658ab20946da5fa86dc9ccc831/discretize/MeshIO.py#L479-L482

I see there are no CI tests for Python 3.5

Issue Analytics

State:
Created 3 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

3reactions

jcapriotcommented, Sep 2, 2020

Hey @banesullivan, I’m certainly in favor of dropping 3.5 support at this point, and also agree that the CI should be done on all current python versions, I’ve been working on getting this all setup using azure pipelines and that engine, which will allow us to have a centralized testing of the package on all OS’s and all versions. It’s also slightly faster than travis’s images.

1reaction

banesullivancommented, Aug 26, 2020

I’m down for dropping 3.5 support … after that though I think discretize’s CIs should test all versions of python >3.5 as quite a number of other libraries have it as a dependency these days.

It may be good to hard set what versions of python are compatible… e.g >3.5,❤️.9 to prevent something like this from happening again