Electron 4 and vibrancy

In reference to #667, release 2.24.0’s electron version now detects the system-wise dark mode status. It can be seen in the sidebar. Selecting Caprine’s light mode while using system-wide dark mode makes the sidebar look wrong. It’s because internally I’ve set the sidebar vibrancy mode to sidebar, which I think changes based on the state of the system dark mode.

With that being said, I plan on making a new pull request which fixes the issue. We have two options here:

1. Stick with the old behavior: app-level dark mode can be set independently of the system-level dark mode. This means that I should avoid using sidebar vibrancy profile, and revert to using light

2. Adapt to the system-level dark mode: This means that we will remove the option to set the app-level dark mode.

I’d like to know your thoughts regarding the direction you want the app to move towards.

[sindresorhus]

I considered doing:

Theme:
- System
- Light
- Dark

But then it’s harder to add a toggle shortcut, and the System would only be there on macOS.

So maybe this would be better?

Follow System Appearance
Dark Mode

Follow System Appearance would only be shown on macOS. If Follow System Appearance is checked, then the Dark Mode menu item would be disabled.

[sindresorhus]

Ah yes, because the menu is initiated statically. Seems we can do it dynamically though. See the example here: https://github.com/electron/electron/issues/11891