Typescript dom reference causes failure in non-DOM contexts

The lib reference to dom https://github.com/sindresorhus/delay/blob/34e50092c96d05f3d248130212a163a22570618f/index.d.ts#L1 prevents this from being properly usable within non-DOM contexts such as react-native.

node_modules/typescript/lib/lib.dom.d.ts:17604:6 - error TS2300: Duplicate identifier 'RequestInfo'.

17604 type RequestInfo = Request | string;
           ~~~~~~~~~~~

node_modules/@types/react-native/globals.d.ts:92:14
92 declare type RequestInfo = Request | string;
                ~~~~~~~~~~~
RequestInfo' was also declared here.

[felixfbecker]

@dex4er “a lot of troubles and incompatibilities” is an over-exaggeration. There was a new feature added to delay in a major version. The way the typings were written caused errors in the new major version for TypeScript users with a certain tsconfig (a subset of the whole user base). Within a single day of the issue being reported there is a PR with a fix.

I wasn’t aware delay is a library mainly for Node and don’t seem anything indicating it is, nor a reason why it should be.

AbortSignal is not “non-standard”. It’s specced in the DOM standard, but that doesn’t matter - so are many other things that can be used in Node too, like URL or setTimeout.

How exactly can this “conflict with other non-standard libraries”?

This feature is not a proof of concept. It is something that I am using in code that runs in the browser.

It’s optional. You don’t have to provide an AbortSignal. But if you have one, you can supply it now. And since it’s an option, there is nothing preventing delay from also supporting other cancellation tokens in the future if TC39 specifies one too (although I don’t see that happening anytime soon).

[dex4er]

I don’t agree that delay should use any of cancel metod: ClearablePromise or AbortController. There is no standard method for canceling Promise in NodeJS or ECMA yet. As far as delay is a library mainly for Node and still is no consensus how to cancel promises (see https://github.com/tc39/proposal-cancellation/issues/22) then it would be better to remove any non-standard features which can conflict with other non-standard libraries.

BTW, it makes me sad that NodeJS’s EventEmitter has nothing in common with DOM’s signals. Maybe it is better to wait for some standardisation?

I guess you want to make a proof of concept that delay can be used with AbortSignal but in the end it caused that this simple delay module (shouldn’t be more that util.promisify(setTimeout)? caused a lot of troubles and incompatibilities.