Rule proposal: Forbid `...(foo || {})` and `...(foo ?? {})` in object literal

Unlike spread in array literals, spread falsy values in object won’t throw error, and works as expected. There is no need to add empty object {} as fallback.

Fail

const object = {
	foo,
	...(bar || {}),
};

const object = {
	foo,
	...(bar ?? {}),
};

Pass

const object = {
	foo,
	...bar,
};

const array = [
	foo,
	...(bar || []),
];

Not sure about the rule name, prefer-directly-spread? no-useless-empty-object?

Spread falsy value

[
	  0,
	  false,
	  undefined,
      '',
	  NaN,
	  0n,
	  null,
	  document.all, // The only exception, but who care?
].map(value => Object.keys(({...value})).length)

[sindresorhus]

no-useless-fallback-in-spread?

[will-stone]

Thank you @papb, that makes sense 🙂 However, I’m sure I noticed it from a real world example of my issue. I’ll turn the rule back on in my shared eslint config and see if I can find the project it affected. If not, then happy days!