Rule proposal: `return condition` instead of using if/else or ternary with explicit true/false

Not to be confused with https://eslint.org/docs/rules/no-else-return Complementary to https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-ternary.md

Occasionally I see Boolean functions that include multiple returns where a plain return condition would suffice.

Fail

function isLoggedIn() {
	if (state === 'logged-in') {
		return true;
	}

	return false;
}

function isTruthy(value) {
	if (value) {
		return true;
	}

	return false;
}

function isNumber(value) {
	return typeof value === 'number' ? true : false;
}

Pass

function isLoggedIn() {
	return state === 'logged-in';
}

function isTruthy(value) {
	return Boolean(value);
}

function isNumber(value) {
	return typeof value === 'number';
}

[fregante]

Good point, prefer-ternary would change

function isLoggedIn() {
	if (state === 'logged-in') {
		return true;
	}

	return false;
}

to

function isLoggedIn() {
	return state === 'logged-in' ? true : false;
}

and no-unneeded-ternary changes that to

function isLoggedIn() {
	return state === 'logged-in';
}

[fisker]

I’ll find time to fix #1116.