afterResponse hook stops response from resolving

Repro — https://github.com/paambaati/ky-body-timeout-repro

I use ky and ky-universal in a Next.js app and I noticed responses failing with a body-timeout error on the Node.js side only for responses above roughly 50KB in size. I’ve tried tweaking the highWatermark and size options, but it doesn’t seem to have an effect.

I have an afterResponse hook that does some additional stuff like logging the responses, redirecting to my login page if the response is a 401, etc.

If I remove the hook, it works. This is illustrated in my repro where I’ve added a hook with just one console.log statement, and you can see the issue occurring. Returning the res has no effect. If the hook is completely removed on the repro, it works.

CC: @sindresorhus, @sholladay, @szmarczak

[sindresorhus]

I’m willing to target the beta.

[sholladay]

You need to avoid using the three features I mentioned in the linked issue. Each of those features clone the response, which triggers the bug. Using body method shorthands is only one of the relevant features, so using the verbose syntax won’t fix your code on it’s own, as you are still using an afterResponse hook.

Needless to say, it’s a major issue, hence the bounty attached to it.

If you cannot modify your code to avoid using those features, then my recommendation is to fork Ky and update the node-fetch dependency in package.json to use the v3 beta. If you end up doing that, feel free to submit a PR. Otherwise, I’ll take care of it myself within the next few days.