requestAnimationFrame is passed incorrect argument

• FakeTimers version : 10.0.0
• Environment : Jest/JSDOM
• Example URL : N/A
• Other libraries you are using: N/A

What did you expect to happen?

The callback passed to requestAnimationFrame should receive an argument which is the number of seconds since time origin (same as performance.now()). MDN Docs

What actually happens

The callback instead receives clock.now which when compared to performance.now() is almost always orders of magnitude higher.

How to reproduce

// Sometime before:
clock.setSystemTime(new Date(2000, 10, 2));
// Test code
let lastFrameTime = performance.now();
window.requestAnimationFrame((time) => {
    console.log("Delta Time:", time - lastFrameTime); // This will log something like 973152000000
});

Suggestion

I know that performance.now() may not always be available. So I propose that this line be changed from:

args: [clock.now + getTimeToNextFrame()],

to

args: [(performancePresent ? clock.performance.now() : clock.now) + getTimeToNextFrame()],

(I am happy to create a PR if you’d like.)

[CreativeTechGuy]

Sorry, I used some loose language. To keep it simple, the current performance.now() should be passed to the callback when it is called. All of the handling of DOMHisResTimeStamp is already implemented in this library. It is currently used for hrtime() and performance.now(). So nothing fundamentally new needs to be added to make this work. Time origin is already being tracked and updated properly by the library. The only missing piece is that it isn’t being passed as the argument and instead a different time is.

[CreativeTechGuy]

Okay! This PR is out!

(And for the record the other one is a pure addition which has no impact on anything that already exists so it isn’t breaking. But yeah let’s continue the discussion on that other thread.)