question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] Prophet with logistic growth does not work

See original GitHub issue

Describe the bug It is not compatible with the case that the growth parameter of prophet is equal to ‘logistic‘

To Reproduce


from sktime.datasets import load_airline
y = load_airline()
y = y.to_timestamp(freq="M")
y_train, y_test = temporal_train_test_split(y, test_size=36)

y_train_df = pd.DataFrame(y_train,index = y_train.index,columns=['y'])
y_train_df["cap"] = max(y_train_df["y"])
y_train_df['floor'] = 0

forecaster = Prophet(
    growth = 'logistic'
)

forecaster.fit(y_train_df)

Expected behavior

The growth parameter compatible with prophet is equal to ‘logistic‘ Additional context

Versions

from sktime import show_versions; show_versions()

System: python: 3.8.3 (default, Jul 2 2020, 11:26:31) [Clang 10.0.0 ] executable: /Users/baixiaotiao/opt/anaconda3/bin/python machine: macOS-10.16-x86_64-i386-64bit

Python dependencies: pip: 20.1.1 setuptools: 49.2.0.post20200714 sklearn: 0.24.2 sktime: 0.6.1 statsmodels: 0.12.2 numpy: 1.20.3 scipy: 1.5.0 Cython: 0.29.21 pandas: 1.2.5 matplotlib: 3.2.2 joblib: 0.16.0 numba: 0.50.1 pmdarima: 1.8.2 tsfresh: None

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8

github_iconTop GitHub Comments

1reaction
fkiralycommented, Jul 1, 2021

@fkiraly How would your framework deal with a class in which the inner-type depends on user-input?

Assuming that “user input” means behaviour controlled by hyper-parameters set in construction, the paradigm would be reading that hyper-parameter in _fit and dealing with any additional conversion or input logic there. fit would be set up to pass through the supported inner types and otherwise convert to them.

Generally, implementers can do whatever they want in _fit in addition to the “generic” conversions which only take over if nothing smarter is specified.

0reactions
fkiralycommented, Apr 11, 2022

Report of closely related behaviour by @ohbtorres here: https://github.com/alan-turing-institute/sktime/issues/2444

Read more comments on GitHub >

github_iconTop Results From Across the Web

[BUG] Prophet with growth="growth="logistic" and growth_cap ...
Prophet allows logistic grown capacity and/ or floor to be either scalar or array. While fixing #1079 noticed that when set to array...
Read more >
Saturating Forecasts | Prophet - Meta Open Source
Prophet allows you to make forecasts using a logistic growth trend model, ... for every row in the dataframe, and that it does...
Read more >
Is Facebook's "Prophet" the Time-Series Messiah, or Just a ...
Facebook prophet offers "automatic" time series prediction. But does it work?
Read more >
Forecasting of COVID-19 epidemic size in four high hitting ...
In this paper, the authors adopted the Fb-Prophet ML model because it can predict the epidemic trend and derive an epidemic curve.
Read more >
How (Not) to Tune Your Model With Hyperopt - Databricks
For example, xgboost wants an objective function to minimize. For classification, it's often reg:logistic . For regression problems ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found