question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move HampelFilter from transformations to annotation module

See original GitHub issue

Is your feature request related to a problem? Please describe. The HampelFilter was included in the transformation module prior to the addition of the annotation module. It is used to detect outliers, which is an annotation task.

I’ve talked with @aiwalter who added it, and we both think it should be moved to the annotation module in the long-run. But we don’t want to move it without being able to still use it (and other annotators) in a ForecastingPipeline.

Describe the solution you’d like HampelFilter should be moved to the annotation module and refactored to comply with that interface. This should be done in conjunction with completion of #840, which will add a ConditionalImputer transformer that will allow annotators to be used in a ForecastingPipeline.

Describe alternatives you’ve considered The alternative of leaving the HampelFilter in the transformation module is not ideal in the long-run because then we have estimators for the same task (detecting outliers) in more than one module.

Additional context N/A

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:5

github_iconTop GitHub Comments

1reaction
satya-pattnaikcommented, Aug 20, 2021

but what do you need to do according to exog?

Please pardon me, I confused Z=DataFrame with exog. You can ignore that.

0reactions
aiwaltercommented, Aug 19, 2021

Yes I’ll push some changes by coming Monday, and I might need help in adding the exogenous part as mentioned by @aiwalter and to write up some unit tests.

Sure lemme know, but what do you need to do according to exog?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Move HampelFilter from transformations to annotation module
It is used to detect outliers, which is an annotation task. I've talked with @aiwalter who added it, and we both think it...
Read more >
HampelFilter — sktime documentation
Fit to data, then transform it. Fits the transformer to X and y and returns a transformed version of X. State change: Changes...
Read more >
Two-stage motion artefact reduction algorithm for ... - PLOS
The Hampel filter is based on a moving window for detecting outliers in a time series. Usually, HF is used as a robust...
Read more >
Transforming java source code to move annotations from ...
Spoon would work well for this, you would use aField.addAnnotation and aSetter.delete.
Read more >
Two-stage motion artefact reduction algorithm for ... - NCBI
The Hampel filter is based on a moving window for detecting outliers ... R-peak Annotation and Signal Segmentation Algorithm Module (RASA).
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found