android.view.WindowManager$BadTokenException: Unable to add window -- token null is not valid; is your activity running?

Please complete the following information:

• Library Version [v1.1.9]
• Affected Device(s) [General]

Describe the Bug:

We are receiving this crash in our crashlytics console

Fatal Exception: android.view.WindowManager$BadTokenException: Unable to add window -- token null is not valid; is your activity running?
       at android.view.ViewRootImpl.setView(ViewRootImpl.java:710)
       at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:342)
       at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:94)
       at android.widget.PopupWindow.invokePopup(PopupWindow.java:1380)
       at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:1236)
       at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:1193)
       at com.skydoves.balloon.Balloon$showAlignTop$$inlined$show$1.run(Balloon.java:1272)
       at android.os.Handler.handleCallback(Handler.java:751)
       at android.os.Handler.dispatchMessage(Handler.java:95)
       at android.os.Looper.loop(Looper.java:154)
       at android.app.ActivityThread.main(ActivityThread.java:6077)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

This is a dummy implementation of our view for a reference implementation:

class MyCustomView(context: Context) : FrameLayout(context), LifecycleOwner {

    private val myLifeCycle: LifecycleRegistry = LifecycleRegistry(this)

    private val binding: MyCustomViewBinding by lazy {
        MyCustomViewBinding.inflate(
            LayoutInflater.from(context),
            this,
            true
        )
    }

    private val myBalloon by lazy {
        createBalloon(context) {
            setCornerRadius(4f)
            setPadding(14)
            setBackgroundColor(ContextCompat.getColor(context, R.color.text_black))
            setWidthRatio(1f)
            setTextResource(R.string.if_you_want_to_take_more_orders_turn_on_the_auto_acceptance)
            setTextColorResource(R.color.white)
            setTextSize(14f)
            setIconDrawable(context.getDrawableCompat(R.drawable.icon_close))
            setIconSize(16)
            dismissWhenClicked = true
            lifecycleOwner = this@MyCustomView
        }
    }

    override fun onAttachedToWindow() {
        super.onAttachedToWindow()
        myLifeCycle.handleLifecycleEvent(Lifecycle.Event.ON_START)
    }

    override fun onDetachedFromWindow() {
        myLifeCycle.handleLifecycleEvent(Lifecycle.Event.ON_STOP)
        super.onDetachedFromWindow()
    }

    fun observe(viewModel: ViewModel) {
        viewModel.someLiveData.observe(this@MyCustomView) {
            myBalloon.showAlignTop(binding.someView)
        }
    }

}

Expected Behavior:

Don’t receive these crashes.

[znakeeye]

@skydoves @sembozdemir So far, I have not been able to reproduce this error in my setup. Very encouraging! Would be great if someone could confirm the fix in a published app.

[epool]

@skydoves yes, it’s being used in an Activity. The reason why I’m not using myLifeCycle.handleLifecycleEvent(Lifecycle.Event.ON_DESTROY) is because the custom view is being added and removed from its parent programmatically and when it’s added again after being removed I want to still listening the events, otherwise after the Lifecycle.Event.ON_DESTROY the custom view stops receiving the view model events. I’ll try to use the activity as lifecycleOwner = . The weird thing is that the custom view is declared inside of the activity and has the same life cycle scope in theory.