Not nullable body on success

In ApiResponse.Success the data property is nullable. And i understand why it is - it’s just a wrapper around retrofit response logic. But, when i’m using clean suspend fun something(): Type i will get an exception if the returned type is null. Which is good, i do expect that!

If i wanted null to be possible in my response - i would use a nullable type as a generic parameter. If i don’t - my assumption is that in case of success it will always be properly created. The need for another null check does make the whole Success type pointless in my opinion. Because i’m still not sure if it really was a success, i have to do another check…

Have you considered handling that?

[jakoss]

From my perspective 204 should be always by design. So when i want to handle 204 i just don’t require any response type (in Sandwich that could be represented by a Unit type maybe? (I’m not 100% sure about that, but maybe Sandwich could allow 204 as a success only if return type is Unit? Is that even possible in kotlin, not sure here 😃 ).

Or maybe different response handling type, something like NoContentApiResponse instead of ApiResponse. That seems to me like fine explicit solution to that. That way programmer always have to explicitly declare that they do not expect body.

[skydoves]

Released a new stable 1.2.0. 🎉