Add the method to check equality in Block Kit model classes

Reproducible in:

The Slack SDK version

All versions

Steps to reproduce:

from slack_sdk.models.blocks import DividerBlock
DividerBlock() == DividerBlock()

It happens with any pair of equivalent blocks.

Expected result:

True

Actual result:

False

Suggested solution

Implementing __eq__ in JsonObject.

class JsonObject(BaseObject, metaclass=ABCMeta):
    ...
    def __eq__(self, other: Any) -> bool:
        if not isinstance(other, JsonObject):
            return NotImplemented
        return self.to_dict() == other.to_dict()

This would allow testing user functions that accept and/or return Slack SDK models.

[seratch]

Hi @kokko-san, how are you doing?

Are you going to work on this shortly? If you don’t have the bandwidth to work on this in a few days, can I start working on this this week? All the other task items for the next release except this one are ready for release, and we are aiming to ship a new version within a few days.

[seratch]

Hi @kokko-san, thanks for your interest!

As for the change fixing this issue, all you need to do is to verify if all the unit tests pass. Also, we would like to have new test patterns to make sure if the change works as expected. For local development, ./scripts/run_unit_tests.sh (test file path) may be handier.

If you have time to complete the work within a few weeks (ideally within 1 to 2 weeks), we are happy to merge your contribution!