Focuspoint with Eager Loading

Hi,

I’m using eager loading for retrieving some images for my gallery:

{% set employments = craft.entries({ section: 'employments', with: ['photo] }) %}

This works fine and I can see all images on my page. But whenever I try to get the focuspoints of that image:

photo[0].focusPctX All images have the same focuspoints (50).

Whenever I try to retrieve the images without the Eager Loading function, it works fine.

Is this a known ‘bug’, or is Eager Loading just not supported by Focuspoint?

[aaronwaldon]

I know I’m a little late, but I was able to get eager loading to work with Focus Point by adding the following method in FocusPoint_AssetElementType.php:

	/**
	 * Adds the focusX and focusY points to the row that populates the model. This
	 * allows the focus point to still work with eager loading.
	 * 
	 * @param DbCommand $query
	 * @param ElementCriteriaModel $criteria
	 */
	public function modifyElementsQuery(DbCommand $query, ElementCriteriaModel $criteria)
	{
		$query
			->addSelect('ff.focusX, ff.focusY')
			->leftJoin('focuspoint_focuspoints ff', 'ff.assetId = elements.id');

		parent::modifyElementsQuery($query, $criteria);
	}

Hope that helps! Just added a pull request: #18

[terryupton]

I am having issues with Eager Loading still. See these posts. aelvan/Imager-Craft#168 (comment) and #22

I am still trying to get to the bottom of it and understand exactly what is causing this to fallover, it seems as though it is getting a value from a previous asset or something?

Digging a little deeper into the database, I noticed two rows for the same asset.

****id**
10813

**assetId**
1988

**fieldId**
31

**focusX**
0.07

**focusY**
0.17

**sourceId**
1989

**dateCreated**
2018-04-26 20:24:39

**dateUpdated**
2018-04-26 20:24:39

**uid**
6bfbb940-d66e-418d-b211-6dfa6676acd3


****id**
5604

**assetId**
1988

**fieldId**
9

**focusX**
0.01

**focusY**
-0.04

**sourceId**
1989

**dateCreated**
2018-03-03 13:52:24

**dateUpdated**
2018-03-03 13:52:24

**uid**
f68806d6-e332-4881-b5ce-014fe2159571

I am wondering if with this fix, it is in-fact getting/selecting the wrong FocusPoint, where it has been used for a different field. Is there a way to extend this to match the right field ID?

I might be wrong in my assumption, but my PHP isn’t strong enough to test or resolve.

Thanks.