question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Form should accept all form props

See original GitHub issue

I need to be able to apply className and action in some cases; it’d be convenient for the form to accept all the props that a form can accept.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

3reactions
smeijercommented, Sep 16, 2021

I’ve published this as a minor, and it’s available under 1.1.0. I don’t think it makes sense to publish 2.0 after only 3 days of existence 😅

The minor is as per semantic version prescribes.

Use your best judgment. If you have a huge audience that will be drastically impacted by changing the behavior back to what the public API intended, then it may be best to perform a major version release, even though the fix could strictly be considered a patch release.

This will be the only time that I’ll introduce a breaking change like this. But because we are 3 days old and have under 200 installs @ npm, I think it’s okay(ish) for now.

1reaction
itsMapleLeafcommented, Sep 16, 2021

I looked back at the form code, and I see there’s already onSuccess and onError, so I think calling the user’s onSubmit on submit start would make sense. They might need the event for whatever reason ¯\_(ツ)_/¯

On an unrelated note, I’m enjoying this library a lot so far 😄

Read more comments on GitHub >

github_iconTop Results From Across the Web

Forms - React
Specifying the value prop on a controlled component prevents the user from changing the input unless you desire so. If you've specified a...
Read more >
The Form element - HTML: HyperText Markup Language | MDN
The HTML element represents a document section containing interactive controls for submitting information.
Read more >
<Form /> props - react-jsonschema-form documentation
The value of this prop will be passed to the accept-charset HTML attribute on the form. action¶. The value of this prop will...
Read more >
Working with Forms in React - SitePoint
This article will walk you through the basics of using forms in React to allow users to add or edit information. We'll look...
Read more >
BEST Ways to Handle and Validate React Forms without a ...
React form validation tutorial. How to handle and validate React form inputs using different ways. Handling forms in React using useState, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found