Use "getter" pattern to derive current stats in Pokemon class

I want to propose computing the current “real” stats for a pokemon at access time instead of constructor time. I think this might clean up some weird logic, and also make it easier to display the effect of stat boosts, items, and abilities on a pokemon’s real stats.

This could look like changing .stats to .getStats() on the Pokemon class, or if we want to be clever, it could even be a property “getter” pattern.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get

This would obviously require some refactoring in the calculation logic though, so I wanted to ask before investing any time in it.

[Zarel]

I also don’t like getters in general; I think they make code less readable compared to just adding () after the variable name so it’s clear that it’s a function call.

[Zarel]

I wrote this helper, but it seems to me it only sort of works by accident that most of the properties of a pokemon overlap with the shape the constructor expects.

No, that’s not a hack, the constructors intentionally support new Pokemon(pokemon) to clone.