Support dynamic WS endpoint by using browserURL

🐛 Bug Report

Puppeteer introduced a new connect property called browserURL which basically does the dynamic WS endpoint fetch for you, see here: https://github.com/GoogleChrome/puppeteer/pull/3558 The problem is that the code adds the browserWSEndpoint no matter what config you give it, see: https://github.com/smooth-code/jest-puppeteer/blob/master/packages/jest-environment-puppeteer/src/PuppeteerEnvironment.js#L40

I’m running chrome in a docker container (https://hub.docker.com/r/justinribeiro/chrome-headless/) so basically my config is just:

connect: {
    browserURL: 'http://127.0.0.1:9222'
}

When running my tests, I’m getting this error:

TypeError: Cannot read property 'removeListener' of undefined

This happens because launching puppeteer fails and the exception is never catched so teardown happens:

Error: Exactly one of browserWSEndpoint, browserURL or transport must be passed to puppeteer.connect

[shayke]

I’m pretty sure this is now fixed due to #212 no? I’ve opened this ticket before those changes in the code where the browserWSEndpoint was always provided to puppeteer.

[lukaszfiszer]

@shayke yeah, #212 definitely fixes this, so I guess @neoziro can now close this issue.